diff options
| author | Peter Xu <peterx@redhat.com> | 2025-09-03 10:29:32 -0400 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2025-09-15 12:00:12 -0400 |
| commit | c75847f9eb8fb09dde0c0f4fa4710c6bde11f5a9 (patch) | |
| tree | 38e96dc2353efcb9bf54b66539c30d9f9ba6eada | |
| parent | 190d5d7fd725ff754f94e8e0cbfb69f279c82b5d (diff) | |
| download | focaccia-qemu-c75847f9eb8fb09dde0c0f4fa4710c6bde11f5a9.tar.gz focaccia-qemu-c75847f9eb8fb09dde0c0f4fa4710c6bde11f5a9.zip | |
memory: Fix addr/len for flatview_access_allowed()
flatview_access_allowed() should pass in the address offset of the memory
region, rather than the global address space. Shouldn't be a major issue
yet, since the addr is only used in an error log.
Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Fixes: 3ab6fdc91b ("softmmu/physmem: Introduce MemTxAttrs::memory field and MEMTX_ACCESS_ERROR")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20250903142932.1038765-1-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
| -rw-r--r-- | system/physmem.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/system/physmem.c b/system/physmem.c index 311011156c..ddd58e9eb8 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3027,7 +3027,7 @@ static MemTxResult flatview_write(FlatView *fv, hwaddr addr, MemTxAttrs attrs, l = len; mr = flatview_translate(fv, addr, &mr_addr, &l, true, attrs); - if (!flatview_access_allowed(mr, attrs, addr, len)) { + if (!flatview_access_allowed(mr, attrs, mr_addr, l)) { return MEMTX_ACCESS_ERROR; } return flatview_write_continue(fv, addr, attrs, buf, len, @@ -3118,7 +3118,7 @@ static MemTxResult flatview_read(FlatView *fv, hwaddr addr, l = len; mr = flatview_translate(fv, addr, &mr_addr, &l, false, attrs); - if (!flatview_access_allowed(mr, attrs, addr, len)) { + if (!flatview_access_allowed(mr, attrs, mr_addr, l)) { return MEMTX_ACCESS_ERROR; } return flatview_read_continue(fv, addr, attrs, buf, len, |