diff options
| author | Pankaj Gupta <pankaj.gupta@amd.com> | 2024-06-07 13:36:09 -0500 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2024-06-11 14:28:34 +0200 |
| commit | c94eb5db8e409c932da9eb187e68d4cdc14acc5b (patch) | |
| tree | ffc289eb2315a3c32928d8df2d3f41241e4f60c6 | |
| parent | 903916f0a017fe4b7789f1c6c6982333a5a71876 (diff) | |
| download | focaccia-qemu-c94eb5db8e409c932da9eb187e68d4cdc14acc5b.tar.gz focaccia-qemu-c94eb5db8e409c932da9eb187e68d4cdc14acc5b.zip | |
i386/sev: fix unreachable code coverity issue
Set 'finish->id_block_en' early, so that it is properly reset.
Fixes coverity CID 1546887.
Fixes: 7b34df4426 ("i386/sev: Introduce 'sev-snp-guest' object")
Signed-off-by: Pankaj Gupta <pankaj.gupta@amd.com>
Message-ID: <20240607183611.1111100-2-pankaj.gupta@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | target/i386/sev.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/target/i386/sev.c b/target/i386/sev.c index 004c667ac1..7c9df621de 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2165,6 +2165,7 @@ sev_snp_guest_set_id_block(Object *obj, const char *value, Error **errp) struct kvm_sev_snp_launch_finish *finish = &sev_snp_guest->kvm_finish_conf; gsize len; + finish->id_block_en = 0; g_free(sev_snp_guest->id_block); g_free((guchar *)finish->id_block_uaddr); @@ -2184,7 +2185,7 @@ sev_snp_guest_set_id_block(Object *obj, const char *value, Error **errp) return; } - finish->id_block_en = (len) ? 1 : 0; + finish->id_block_en = 1; } static char * |