summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2021-06-02 20:37:09 -0400
committerJohn Snow <jsnow@redhat.com>2021-06-18 16:10:06 -0400
commitd229f1c83d698ed5f605bcc2eab96e05afeddefb (patch)
treeb56db45c425d41b9bb6ba018936c6ed1801b4384
parent26c1ccadc41bf32a720faf4d652eae41c7e54d00 (diff)
downloadfocaccia-qemu-d229f1c83d698ed5f605bcc2eab96e05afeddefb.tar.gz
focaccia-qemu-d229f1c83d698ed5f605bcc2eab96e05afeddefb.zip
python: Add 'fh' to known-good variable names
fd and fh are fine: we often use these for "file descriptor" or "file
handle" accordingly. It is rarely the case that you need to enforce a
more semantically meaningful name beyond "This is the file we are using
right now."

While we're here: add comments for all of the non-standard pylint
names. (And the underscore.)

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20210603003719.1321369-10-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
-rw-r--r--python/setup.cfg7
1 files changed, 4 insertions, 3 deletions
diff --git a/python/setup.cfg b/python/setup.cfg
index a19029d538..c9b9445af9 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -78,9 +78,10 @@ good-names=i,
            k,
            ex,
            Run,
-           _,
-           fd,
-           c,
+           _,   # By convention: Unused variable
+           fh,  # fh = open(...)
+           fd,  # fd = os.open(...)
+           c,   # for c in string: ...
 
 [pylint.similarities]
 # Ignore imports when computing similarities.