diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2021-10-07 18:17:03 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2021-10-13 10:47:49 +0200 |
| commit | d58d9f55a78a69730b4f1641f1c969d8585b970b (patch) | |
| tree | b8af5c675dee848e41c12989048e7380a49a38bd | |
| parent | 4e7189e112966ac3a7bc884273a8b07291c3012e (diff) | |
| download | focaccia-qemu-d58d9f55a78a69730b4f1641f1c969d8585b970b.tar.gz focaccia-qemu-d58d9f55a78a69730b4f1641f1c969d8585b970b.zip | |
target/i386/sev: Mark unreachable code with g_assert_not_reached()
The unique sev_encrypt_flash() invocation (in pc_system_flash_map) is protected by the "if (sev_enabled())" check, so is not reacheable. Replace the abort() call in sev_es_save_reset_vector() by g_assert_not_reached() which meaning is clearer. Reviewed-by: Connor Kuehl <ckuehl@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20211007161716.453984-11-philmd@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | target/i386/sev-stub.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c index 20b1e18ec1..55f1ec7419 100644 --- a/target/i386/sev-stub.c +++ b/target/i386/sev-stub.c @@ -54,7 +54,7 @@ int sev_inject_launch_secret(const char *hdr, const char *secret, int sev_encrypt_flash(uint8_t *ptr, uint64_t len, Error **errp) { - return 0; + g_assert_not_reached(); } bool sev_es_enabled(void) @@ -68,7 +68,7 @@ void sev_es_set_reset_vector(CPUState *cpu) int sev_es_save_reset_vector(void *flash_ptr, uint64_t flash_size) { - abort(); + g_assert_not_reached(); } SevAttestationReport * |