diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2016-09-22 11:13:08 +0100 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2016-09-28 12:55:09 +0200 |
| commit | d9d2663c336b4ff7af9528f2cd3736791f4c0da5 (patch) | |
| tree | 3f8f98c2db01794b93a1b484d99d01ecef43fc64 | |
| parent | 4423184376dc85849b2d7b4660e7feeb2b38bf6f (diff) | |
| download | focaccia-qemu-d9d2663c336b4ff7af9528f2cd3736791f4c0da5.tar.gz focaccia-qemu-d9d2663c336b4ff7af9528f2cd3736791f4c0da5.zip | |
ui/vnc-enc-tight: remove switch and have single return
When enabling the sanitizer build it will complain about control reaching a non-void function. Normally the compiler should detect that there is only one possible exit given a static VNC_SERVER_FB_BYTES. As we always expect a static VNC_SERVER_FB_BYTES I've added a compile time assert and just called the sub-function directly. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | ui/vnc-enc-tight.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 49df85e763..1e53b1cf84 100644 --- a/ui/vnc-enc-tight.c +++ b/ui/vnc-enc-tight.c @@ -707,10 +707,8 @@ check_solid_tile32(VncState *vs, int x, int y, int w, int h, static bool check_solid_tile(VncState *vs, int x, int y, int w, int h, uint32_t* color, bool samecolor) { - switch (VNC_SERVER_FB_BYTES) { - case 4: - return check_solid_tile32(vs, x, y, w, h, color, samecolor); - } + QEMU_BUILD_BUG_ON(VNC_SERVER_FB_BYTES != 4); + return check_solid_tile32(vs, x, y, w, h, color, samecolor); } static void find_best_solid_area(VncState *vs, int x, int y, int w, int h, |