diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2013-09-12 11:02:18 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2013-09-18 15:48:33 +0200 |
| commit | da718ceb1730bfe6fea0178df979639b14a0646e (patch) | |
| tree | bd51378e7e1cebebd155acc2bb6751ef2f1b2210 | |
| parent | a5813077aac7865f69b7ee46a594f3705429f7cd (diff) | |
| download | focaccia-qemu-da718ceb1730bfe6fea0178df979639b14a0646e.tar.gz focaccia-qemu-da718ceb1730bfe6fea0178df979639b14a0646e.zip | |
qemu-timer: drop outdated signal safety comments
host_alarm_handler() is invoked from the signal processing thread (currently the iothread). Previously we did processing in a real signal handler with signalfd and therefore needed signal-safe timer code. Today host_alarm_handler() just marks the alarm timer as expired/pending and notifies the main loop using qemu_notify_event(). Therefore these outdated comments about signal safety can be dropped. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | qemu-timer.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/qemu-timer.c b/qemu-timer.c index 95ff47fef3..ed3fcb2190 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -301,8 +301,6 @@ void timer_del(QEMUTimer *ts) { QEMUTimer **pt, *t; - /* NOTE: this code must be signal safe because - timer_expired() can be called from a signal. */ pt = &ts->timer_list->active_timers; for(;;) { t = *pt; @@ -325,8 +323,6 @@ void timer_mod_ns(QEMUTimer *ts, int64_t expire_time) timer_del(ts); /* add the timer in the sorted list */ - /* NOTE: this code must be signal safe because - timer_expired() can be called from a signal. */ pt = &ts->timer_list->active_timers; for(;;) { t = *pt; |