summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2025-10-03 14:18:17 +0000
committerAlex Bennée <alex.bennee@linaro.org>2025-10-07 07:33:40 +0100
commitdb205774d1b2dc8e3a0e925f090a5b2f59b9bb70 (patch)
treed730c7c2bda9b41401433bd334b2fa439021eedd
parenta0ad64c390b19242ae1d246d1ccfff77dcc752a4 (diff)
downloadfocaccia-qemu-db205774d1b2dc8e3a0e925f090a5b2f59b9bb70.tar.gz
focaccia-qemu-db205774d1b2dc8e3a0e925f090a5b2f59b9bb70.zip
tests/functional: drop datadrainer class in reverse debugging
The reverse debugging test uses the avocado datadrainer class to
create a background thread that reads from the console socket and
dumps it via python logger.

Most tests log console output as a side effect of doing calls
to match strings, but this test never tries to match anything.

This isn't critical, so just drop the functionality.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20251003141820.85278-7-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
-rw-r--r--tests/functional/reverse_debugging.py6
1 files changed, 0 insertions, 6 deletions
diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py
index a7ff47cb90..7fd8c7607f 100644
--- a/tests/functional/reverse_debugging.py
+++ b/tests/functional/reverse_debugging.py
@@ -34,8 +34,6 @@ class ReverseDebugging(LinuxKernelTest):
     endian_is_le = True
 
     def run_vm(self, record, shift, args, replay_path, image_path, port):
-        from avocado.utils import datadrainer
-
         logger = logging.getLogger('replay')
         vm = self.get_vm(name='record' if record else 'replay')
         vm.set_console()
@@ -53,10 +51,6 @@ class ReverseDebugging(LinuxKernelTest):
         if args:
             vm.add_args(*args)
         vm.launch()
-        console_drainer = datadrainer.LineLogger(vm.console_socket.fileno(),
-                                    logger=self.log.getChild('console'),
-                                    stop_check=(lambda : not vm.is_running()))
-        console_drainer.start()
         return vm
 
     @staticmethod