diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-06-09 14:23:39 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-06-15 21:36:30 +0200 |
| commit | dfe8c79c44680e34eac2e8abd0d0c885ce01aa55 (patch) | |
| tree | 1c1b73029388a02f505c1773034e112fa63aa470 | |
| parent | 007d1dbf72536ec1b847a944832e4de1546af2ac (diff) | |
| download | focaccia-qemu-dfe8c79c44680e34eac2e8abd0d0c885ce01aa55.tar.gz focaccia-qemu-dfe8c79c44680e34eac2e8abd0d0c885ce01aa55.zip | |
qdev: Assert onboard devices all get realized properly
This would have caught some of the bugs I just fixed. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200609122339.937862-25-armbru@redhat.com>
| -rw-r--r-- | hw/core/qdev.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/hw/core/qdev.c b/hw/core/qdev.c index b5b42b2616..a68ba674db 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -427,6 +427,19 @@ void qdev_init_nofail(DeviceState *dev) object_unref(OBJECT(dev)); } +static int qdev_assert_realized_properly(Object *obj, void *opaque) +{ + DeviceState *dev = DEVICE(object_dynamic_cast(obj, TYPE_DEVICE)); + DeviceClass *dc; + + if (dev) { + dc = DEVICE_GET_CLASS(dev); + assert(dev->realized); + assert(dev->parent_bus || !dc->bus_type); + } + return 0; +} + void qdev_machine_creation_done(void) { /* @@ -434,6 +447,9 @@ void qdev_machine_creation_done(void) * only create hotpluggable devices */ qdev_hotplug = true; + + object_child_foreach_recursive(object_get_root(), + qdev_assert_realized_properly, NULL); } bool qdev_machine_modified(void) |