diff options
| author | Akihiko Odaki <akihiko.odaki@daynix.com> | 2024-01-29 17:03:07 +0900 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2024-02-14 06:09:33 -0500 |
| commit | e8ddec58053e9361b2cc18ec6d17b6c95590bf3c (patch) | |
| tree | d7d318d3cff7f31652c8d8b3205f227bce154252 | |
| parent | 574b64aa6754ba491f51024c5a823a674d48a658 (diff) | |
| download | focaccia-qemu-e8ddec58053e9361b2cc18ec6d17b6c95590bf3c.tar.gz focaccia-qemu-e8ddec58053e9361b2cc18ec6d17b6c95590bf3c.zip | |
hw/smbios: Fix OEM strings table option validation
qemu_smbios_type11_opts did not have the list terminator and that
resulted in out-of-bound memory access. It also needs to have an element
for the type option.
Cc: qemu-stable@nongnu.org
Fixes: 2d6dcbf93fb0 ("smbios: support setting OEM strings table")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20240129-smbios-v2-1-9ee6fede0d10@daynix.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | hw/smbios/smbios.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index c0c5a81e66..a9048c1342 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -376,6 +376,11 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = { static const QemuOptDesc qemu_smbios_type11_opts[] = { { + .name = "type", + .type = QEMU_OPT_NUMBER, + .help = "SMBIOS element type", + }, + { .name = "value", .type = QEMU_OPT_STRING, .help = "OEM string data", @@ -385,6 +390,7 @@ static const QemuOptDesc qemu_smbios_type11_opts[] = { .type = QEMU_OPT_STRING, .help = "OEM string data from file", }, + { /* end of list */ } }; static const QemuOptDesc qemu_smbios_type17_opts[] = { |