diff options
| author | Stefan Berger <stefanb@linux.vnet.ibm.com> | 2018-11-20 13:14:51 -0500 |
|---|---|---|
| committer | Stefan Berger <stefanb@linux.vnet.ibm.com> | 2018-12-04 10:21:25 -0500 |
| commit | e92b63ea610201bd743343fc6b11e6c39c8d3515 (patch) | |
| tree | 19f3b25e643b69e18f53451872ede36ba7ab85ec | |
| parent | 0f5faee3592ef7ce004a79eeff0061ee4362b428 (diff) | |
| download | focaccia-qemu-e92b63ea610201bd743343fc6b11e6c39c8d3515.tar.gz focaccia-qemu-e92b63ea610201bd743343fc6b11e6c39c8d3515.zip | |
tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid
Make sure that the new locality passed to tpm_tis_prep_abort() is valid. Add a comment to aborting_locty that it may be any locality, including TPM_TIS_NO_LOCALITY. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
| -rw-r--r-- | hw/tpm/tpm_tis.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 176d424ed9..04e4ad9212 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -263,7 +263,9 @@ static void tpm_tis_prep_abort(TPMState *s, uint8_t locty, uint8_t newlocty) { uint8_t busy_locty; - s->aborting_locty = locty; + assert(TPM_TIS_IS_VALID_LOCTY(newlocty)); + + s->aborting_locty = locty; /* may also be TPM_TIS_NO_LOCALITY */ s->next_locty = newlocty; /* locality after successful abort */ /* |