summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorDaniel P. Berrange <berrange@redhat.com>2016-09-29 16:45:32 +0100
committerGerd Hoffmann <kraxel@redhat.com>2016-10-13 09:21:02 +0200
commitecccaea2f5769bb909c7a3510dc3ff9dbd736249 (patch)
tree7927bc3cfec71942254f0b322839310842db39eb
parentc264a8807299852fc45562768ae60ccc886cea91 (diff)
downloadfocaccia-qemu-ecccaea2f5769bb909c7a3510dc3ff9dbd736249.tar.gz
focaccia-qemu-ecccaea2f5769bb909c7a3510dc3ff9dbd736249.zip
ui: remove misleading comment from vnc_init_state
The last line in vnc_init_state() says

     /* vs might be free()ed here */

This was added in

  commit 198a0039c5fca224a77e9761e2350dd9cc102ad0
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   Tue Jun 16 14:19:48 2009 +0200

    vnc: rework VncState release workflow.

because the preceeding 'vnc_update_client()' could indeed
release the VncState instance.

The call to vnc_update_client() was removed not long after
though in

  commit 1fc624122fb923c7fc4c1f426541d953e7df13c9
  Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
  Date:   Mon Aug 3 10:54:32 2009 +0100

    single vnc server surface

and so the comment has been wrong ever since

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 1475163940-26094-2-git-send-email-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
-rw-r--r--ui/vnc.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/ui/vnc.c b/ui/vnc.c
index 76a3273e0b..5faf79bc4d 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3092,8 +3092,6 @@ void vnc_init_state(VncState *vs)
 
     vs->mouse_mode_notifier.notify = check_pointer_type_change;
     qemu_add_mouse_mode_change_notifier(&vs->mouse_mode_notifier);
-
-    /* vs might be free()ed here */
 }
 
 static gboolean vnc_listen_io(QIOChannel *ioc,