summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLi Qiang <liqiang6-s@360.cn>2016-10-17 14:13:58 +0200
committerGreg Kurz <groug@kaod.org>2016-10-17 14:13:58 +0200
commitfdfcc9aeea1492f4b819a24c94dfb678145b1bf9 (patch)
tree52b31c58fb39440398d2e623a47d8db692108951
parent4c1586787ff43c9acd18a56c12d720e3e6be9f7c (diff)
downloadfocaccia-qemu-fdfcc9aeea1492f4b819a24c94dfb678145b1bf9.tar.gz
focaccia-qemu-fdfcc9aeea1492f4b819a24c94dfb678145b1bf9.zip
9pfs: fix memory leak in v9fs_write
If an error occurs when marshalling the transfer length to the guest, the
v9fs_write() function doesn't free an IO vector, thus leading to a memory
leak. This patch fixes the issue.

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Greg Kurz <groug@kaod.org>
[groug, rephrased the changelog]
Signed-off-by: Greg Kurz <groug@kaod.org>
-rw-r--r--hw/9pfs/9p.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index d43a552234..e88cf257a2 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -2090,7 +2090,7 @@ static void coroutine_fn v9fs_write(void *opaque)
     offset = 7;
     err = pdu_marshal(pdu, offset, "d", total);
     if (err < 0) {
-        goto out;
+        goto out_qiov;
     }
     err += offset;
     trace_v9fs_write_return(pdu->tag, pdu->id, total, err);