summary refs log tree commit diff stats
path: root/accel/accel-system.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2024-10-29 10:43:16 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2024-10-31 18:28:32 +0100
commit8aade934dfa6ef9a1ca20666078e7c2d19e56368 (patch)
treefdb6dfa276752181e57cf1c42c41272fb0627cbf /accel/accel-system.c
parent3139ad088b52ab840d760d40962fc0db57c62d83 (diff)
downloadfocaccia-qemu-8aade934dfa6ef9a1ca20666078e7c2d19e56368.tar.gz
focaccia-qemu-8aade934dfa6ef9a1ca20666078e7c2d19e56368.zip
accel: remove dead statement and useless assertion
ops is assigned again just below, and the result of the assignment must
be non-NULL.

Originally, the check for NULL was meant to be a check for the existence
of the ops class:

    ops = ACCEL_OPS_CLASS(object_class_by_name(ops_name));
    ...
    g_assert(ops != NULL);

(where the ops assignment begot the one that I am removing); but this is
meaningless now that oc is checked to be non-NULL before ops is assigned
(commit 5141e9a23fc, "accel: abort if we fail to load the accelerator
plugin", 2022-11-06).

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'accel/accel-system.c')
-rw-r--r--accel/accel-system.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/accel/accel-system.c b/accel/accel-system.c
index f6c947dd82..61d689935e 100644
--- a/accel/accel-system.c
+++ b/accel/accel-system.c
@@ -73,19 +73,17 @@ void accel_system_init_ops_interfaces(AccelClass *ac)
     g_assert(ac_name != NULL);
 
     ops_name = g_strdup_printf("%s" ACCEL_OPS_SUFFIX, ac_name);
-    ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name));
     oc = module_object_class_by_name(ops_name);
     if (!oc) {
         error_report("fatal: could not load module for type '%s'", ops_name);
         exit(1);
     }
     g_free(ops_name);
-    ops = ACCEL_OPS_CLASS(oc);
     /*
      * all accelerators need to define ops, providing at least a mandatory
      * non-NULL create_vcpu_thread operation.
      */
-    g_assert(ops != NULL);
+    ops = ACCEL_OPS_CLASS(oc);
     if (ops->ops_init) {
         ops->ops_init(ops);
     }