summary refs log tree commit diff stats
path: root/backends/cryptodev-vhost-user.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2022-10-12 17:37:59 +0200
committerMarkus Armbruster <armbru@redhat.com>2022-10-27 07:56:56 +0200
commitff924448849f4fca48df15ecad67dc93854392e5 (patch)
tree73797ff424969e0b3d5a42d57dbdd40d64aaba9f /backends/cryptodev-vhost-user.c
parent3f7febc93785bf0e622072b01f846d2acbcd9c0b (diff)
downloadfocaccia-qemu-ff924448849f4fca48df15ecad67dc93854392e5.tar.gz
focaccia-qemu-ff924448849f4fca48df15ecad67dc93854392e5.zip
backends: Improve error messages when property can no longer be set
When you try to set virtio-rng property "filename" after the backend
has been completed with user_creatable_complete(), the error message
blames "insufficient permission":

    $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -object rng-random,id=rng0 -device virtio-rng,id=vrng0,rng=rng0
    QEMU 7.1.50 monitor - type 'help' for more information
    (qemu) qom-set /objects/rng0 filename /dev/random
    Error: Insufficient permission to perform this operation

This implies it could work with "sufficient permission".  It can't.
Change the error message to:

    Error: Property 'filename' can no longer be set

Same for cryptodev-vhost-user property "chardev", rng-egd property
"chardev", and vhost-user-backend property "chardev".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221012153801.2604340-3-armbru@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
[Commit message tidied up]
Diffstat (limited to 'backends/cryptodev-vhost-user.c')
-rw-r--r--backends/cryptodev-vhost-user.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
index 5443a59153..f9c5867e38 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -339,7 +339,7 @@ static void cryptodev_vhost_user_set_chardev(Object *obj,
                       CRYPTODEV_BACKEND_VHOST_USER(obj);
 
     if (s->opened) {
-        error_setg(errp, QERR_PERMISSION_DENIED);
+        error_setg(errp, "Property 'chardev' can no longer be set");
     } else {
         g_free(s->chr_name);
         s->chr_name = g_strdup(value);