diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-09-29 16:51:49 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-10-12 16:31:33 +0200 |
| commit | 0bb79c97fd8e355aca433f4331d7d45e7e72b4b6 (patch) | |
| tree | f3fe385db7fe95942384ecc382ee644962b7a45d /block.c | |
| parent | bd131d6705b6996f2cdccee3db017af570ce91ad (diff) | |
| download | focaccia-qemu-0bb79c97fd8e355aca433f4331d7d45e7e72b4b6.tar.gz focaccia-qemu-0bb79c97fd8e355aca433f4331d7d45e7e72b4b6.zip | |
qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of qcow2_signal_corruption() need to hold a reader lock for the graph because it calls bdrv_get_node_name(), which accesses the parents list of a node. For some places, we know that they will hold the lock, but we don't have the GRAPH_RDLOCK annotations yet. In this case, add assume_graph_lock() with a FIXME comment. These places will be removed once everything is properly annotated. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-ID: <20230929145157.45443-15-kwolf@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
| -rw-r--r-- | block.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/block.c b/block.c index c932dc0a51..d1a3466069 100644 --- a/block.c +++ b/block.c @@ -7250,7 +7250,8 @@ bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType op, Error **errp) { BdrvOpBlocker *blocker; GLOBAL_STATE_CODE(); - GRAPH_RDLOCK_GUARD_MAINLOOP(); + + assume_graph_lock(); /* FIXME */ assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX); if (!QLIST_EMPTY(&bs->op_blockers[op])) { |