summary refs log tree commit diff stats
path: root/block.c
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2024-03-12 14:03:37 +0800
committerThomas Huth <thuth@redhat.com>2024-03-12 11:45:45 +0100
commit46ff64a826bbd70e98484c8c7f4c3c1d83363f1d (patch)
tree05517ade1c9a4471589aa744ffd7989eda4821d8 /block.c
parent95e9053a34ca99b90f47073a30e02fa00afc3aeb (diff)
downloadfocaccia-qemu-46ff64a826bbd70e98484c8c7f4c3c1d83363f1d.tar.gz
focaccia-qemu-46ff64a826bbd70e98484c8c7f4c3c1d83363f1d.zip
error: Move ERRP_GUARD() to the beginning of the function
Since the commit 05e385d2a9 ("error: Move ERRP_GUARD() to the beginning
of the function"), there are new codes that don't put ERRP_GUARD() at
the beginning of the functions.

As stated in the commit 05e385d2a9: "include/qapi/error.h advises to put
ERRP_GUARD() right at the beginning of the function, because only then
can it guard the whole function.", so clean up the few spots
disregarding the advice.

Inspired-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240312060337.3240965-1-zhao1.liu@linux.intel.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r--block.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block.c b/block.c
index cf66c767a0..468cf5e67d 100644
--- a/block.c
+++ b/block.c
@@ -534,9 +534,9 @@ typedef struct CreateCo {
 int coroutine_fn bdrv_co_create(BlockDriver *drv, const char *filename,
                                 QemuOpts *opts, Error **errp)
 {
+    ERRP_GUARD();
     int ret;
     GLOBAL_STATE_CODE();
-    ERRP_GUARD();
 
     if (!drv->bdrv_co_create_opts) {
         error_setg(errp, "Driver '%s' does not support image creation",