summary refs log tree commit diff stats
path: root/bsd-user/syscall.c
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2020-02-07 01:14:04 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2020-02-07 16:49:39 +0000
commit11a18c84db4a71497d3d40769688a01b6f64b2ad (patch)
tree31cec2f53b0afe08fcef6833aa3f1ebea8a372bc /bsd-user/syscall.c
parentac9d00bf7b47acae6b0e42910d9ed55fef3af5b8 (diff)
downloadfocaccia-qemu-11a18c84db4a71497d3d40769688a01b6f64b2ad.tar.gz
focaccia-qemu-11a18c84db4a71497d3d40769688a01b6f64b2ad.zip
hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host
Commit ed65fd1a2750 ("virtio-blk: switch off scsi-passthrough by
default") changed the default value of the 'scsi' property of
virtio-blk, which is only available on Linux hosts. It also added
an unconditional compat entry for 2.4 or earlier machines.

Trying to set this property on a pre-2.5 machine on OSX, we get:

   Unexpected error in object_property_find() at qom/object.c:1201:
   qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found

Fix this error by marking the property optional.

Fixes: ed65fd1a27 ("virtio-blk: switch off scsi-passthrough by default")
Suggested-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20200207001404.1739-1-philmd@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'bsd-user/syscall.c')
0 files changed, 0 insertions, 0 deletions