diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> | 2025-09-16 16:13:51 +0300 |
|---|---|---|
| committer | Daniel P. Berrangé <berrange@redhat.com> | 2025-09-19 12:46:07 +0100 |
| commit | 9adc8d052d1c6b3015ca07a6a0f0833fb725e06f (patch) | |
| tree | e4f0f6f2b1af6e13bb5ba48a158df98cda716a2b /chardev/char-socket.c | |
| parent | 6e9a6d57bf8de9e1edc207c24ed4e9e9508838c1 (diff) | |
| download | focaccia-qemu-9adc8d052d1c6b3015ca07a6a0f0833fb725e06f.tar.gz focaccia-qemu-9adc8d052d1c6b3015ca07a6a0f0833fb725e06f.zip | |
char-socket: tcp_chr_recv(): add comment
Add comment, to stress that the order of operation (first drop old fds, second check read status) is intended. Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'chardev/char-socket.c')
| -rw-r--r-- | chardev/char-socket.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/chardev/char-socket.c b/chardev/char-socket.c index b1ce5d01c7..1be078dfc0 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -294,7 +294,12 @@ static ssize_t tcp_chr_recv(Chardev *chr, char *buf, size_t len) } if (msgfds_num) { - /* close and clean read_msgfds */ + /* + * Close and clean previous read_msgfds, they are obsolete at + * this point, regardless result of new call to + * qio_channel_readv_full(). + */ + for (i = 0; i < s->read_msgfds_num; i++) { close(s->read_msgfds[i]); } |