diff options
| author | Nicholas Piggin <npiggin@gmail.com> | 2024-08-28 14:33:34 +1000 |
|---|---|---|
| committer | Marc-André Lureau <marcandre.lureau@redhat.com> | 2024-12-03 16:09:19 +0400 |
| commit | 651b386205d7578e8de60df0ec3830b315f6686f (patch) | |
| tree | adbb20f03edbff8a718029568a5f484abd8b4a64 /chardev/char.c | |
| parent | eb22a064455aeebc105cc89bf77f48aa18b52938 (diff) | |
| download | focaccia-qemu-651b386205d7578e8de60df0ec3830b315f6686f.tar.gz focaccia-qemu-651b386205d7578e8de60df0ec3830b315f6686f.zip | |
chardev: Fix record/replay error path NULL deref in device creation
qemu_chardev_set_replay() was being called in chardev creation to
set up replay parameters even if the chardev is NULL.
A segfault can be reproduced by specifying '-serial chardev:bad' with
an rr=record mode.
Fix this with a NULL pointer check.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Resolves: Coverity CID 1559470
Fixes: 4c193bb129dae ("chardev: set record/replay on the base device of a muxed device")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20240828043337.14587-2-npiggin@gmail.com>
Diffstat (limited to 'chardev/char.c')
| -rw-r--r-- | chardev/char.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chardev/char.c b/chardev/char.c index a1722aa076..1c7f6c711a 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -726,7 +726,7 @@ static Chardev *__qemu_chr_new(const char *label, const char *filename, if (strstart(filename, "chardev:", &p)) { chr = qemu_chr_find(p); - if (replay) { + if (replay && chr) { qemu_chardev_set_replay(chr, &err); if (err) { error_report_err(err); |