summary refs log tree commit diff stats
path: root/common-user
diff options
context:
space:
mode:
authorIcenowy Zheng <uwu@icenowy.me>2025-04-17 15:22:06 +0800
committerAlistair Francis <alistair.francis@wdc.com>2025-05-19 13:38:04 +1000
commit22b448ccc6611a59d4aa54419f4d88c1f343cb35 (patch)
tree8e2cf5a114749a4eb3bc00b912e6187aa14a7162 /common-user
parentad63158bdb33dab5704ea1cf740d2ea0387175df (diff)
downloadfocaccia-qemu-22b448ccc6611a59d4aa54419f4d88c1f343cb35.tar.gz
focaccia-qemu-22b448ccc6611a59d4aa54419f4d88c1f343cb35.zip
common-user/host/riscv: use tail pseudoinstruction for calling tail
The j pseudoinstruction maps to a JAL instruction, which can only handle
a jump to somewhere with a signed 20-bit destination. In case of static
linking and LTO'ing this easily leads to "relocation truncated to fit"
error.

Switch to use tail pseudoinstruction, which is the standard way to
tail-call a function in medium code model (emits AUIPC+JALR).

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250417072206.364008-1-uwu@icenowy.me>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Cc: qemu-stable@nongnu.org
Diffstat (limited to 'common-user')
-rw-r--r--common-user/host/riscv/safe-syscall.inc.S4
1 files changed, 2 insertions, 2 deletions
diff --git a/common-user/host/riscv/safe-syscall.inc.S b/common-user/host/riscv/safe-syscall.inc.S
index dfe83c300e..c8b81e33d0 100644
--- a/common-user/host/riscv/safe-syscall.inc.S
+++ b/common-user/host/riscv/safe-syscall.inc.S
@@ -69,11 +69,11 @@ safe_syscall_end:
 
         /* code path setting errno */
 0:      neg     a0, a0
-        j       safe_syscall_set_errno_tail
+        tail    safe_syscall_set_errno_tail
 
         /* code path when we didn't execute the syscall */
 2:      li      a0, QEMU_ERESTARTSYS
-        j       safe_syscall_set_errno_tail
+        tail    safe_syscall_set_errno_tail
 
         .cfi_endproc
         .size   safe_syscall_base, .-safe_syscall_base