diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2020-11-30 11:56:14 +0100 |
|---|---|---|
| committer | Daniel P. Berrangé <berrange@redhat.com> | 2021-01-29 17:07:53 +0000 |
| commit | ab366aae78bcac972a0920ffdda3136fc13fa093 (patch) | |
| tree | d047381b8fe8f2b1bdf823b3aa4f604e75e91029 /crypto/tlscredspsk.c | |
| parent | 668cb74b2af1129349a6c41763bc88d801161e09 (diff) | |
| download | focaccia-qemu-ab366aae78bcac972a0920ffdda3136fc13fa093.tar.gz focaccia-qemu-ab366aae78bcac972a0920ffdda3136fc13fa093.zip | |
crypto: Fix memory leaks in set_loaded for tls-*
If you set the loaded property to true when it was already true, the state is overwritten without freeing the old state first. Change the set_loaded callback so that it always frees the old state (which is a no-op if nothing was loaded) and only then load if requestsd. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'crypto/tlscredspsk.c')
| -rw-r--r-- | crypto/tlscredspsk.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crypto/tlscredspsk.c b/crypto/tlscredspsk.c index e26807b899..f5a31108d1 100644 --- a/crypto/tlscredspsk.c +++ b/crypto/tlscredspsk.c @@ -192,10 +192,9 @@ qcrypto_tls_creds_psk_prop_set_loaded(Object *obj, { QCryptoTLSCredsPSK *creds = QCRYPTO_TLS_CREDS_PSK(obj); + qcrypto_tls_creds_psk_unload(creds); if (value) { qcrypto_tls_creds_psk_load(creds, errp); - } else { - qcrypto_tls_creds_psk_unload(creds); } } |