summary refs log tree commit diff stats
path: root/docs/devel/qapi-code-gen.rst
diff options
context:
space:
mode:
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>2022-01-26 17:11:25 +0100
committerMarkus Armbruster <armbru@redhat.com>2022-01-27 11:25:09 +0100
commit167d913f34aa469fa30b0c51a04d8d2b9a5f1fa5 (patch)
tree451eb32cb8b455c6a39954d194d18f44ec69fe94 /docs/devel/qapi-code-gen.rst
parent4e86df17326d2afaf74622c082d906ed3f96d1d7 (diff)
downloadfocaccia-qemu-167d913f34aa469fa30b0c51a04d8d2b9a5f1fa5.tar.gz
focaccia-qemu-167d913f34aa469fa30b0c51a04d8d2b9a5f1fa5.zip
qapi/commands: refactor error handling code
Move error_propagate() to if (err) and make "if (err)" block mandatory.
This is to simplify further commit, which will bring trace events
generation for QMP commands.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20220126161130.3240892-3-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'docs/devel/qapi-code-gen.rst')
-rw-r--r--docs/devel/qapi-code-gen.rst2
1 files changed, 1 insertions, 1 deletions
diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst
index a3b5473089..feafed79b5 100644
--- a/docs/devel/qapi-code-gen.rst
+++ b/docs/devel/qapi-code-gen.rst
@@ -1690,8 +1690,8 @@ Example::
         }
 
         retval = qmp_my_command(arg.arg1, &err);
-        error_propagate(errp, err);
         if (err) {
+            error_propagate(errp, err);
             goto out;
         }