summary refs log tree commit diff stats
path: root/docs/devel/secure-coding-practices.rst
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2023-11-21 18:40:49 +0100
committerPeter Maydell <peter.maydell@linaro.org>2023-11-27 15:27:43 +0000
commit49b3e28b7bdfe771150d05c4b5860aa7854a4232 (patch)
tree864f075fd5419608e8843f0b950cf4cc224e64d0 /docs/devel/secure-coding-practices.rst
parent896dd6ff7b9f2575f1a908a07f26a70b58d8b675 (diff)
downloadfocaccia-qemu-49b3e28b7bdfe771150d05c4b5860aa7854a4232.tar.gz
focaccia-qemu-49b3e28b7bdfe771150d05c4b5860aa7854a4232.zip
hw/nvram/xlnx-efuse: Free XlnxEFuse::ro_bits[] array on finalize()
Commit 0be6bfac62 ("qdev: Implement variable length array properties")
added the DEFINE_PROP_ARRAY() macro with the following comment:

  * It is the responsibility of the device deinit code to free the
  * @_arrayfield memory.

Commit 68fbcc344e added:

  DEFINE_PROP_ARRAY("read-only", XlnxEFuse, ro_bits_cnt, ro_bits,
                    qdev_prop_uint32, uint32_t),

but forgot to free the 'ro_bits' array. Do it in the instance_finalize
handler.

Cc: qemu-stable@nongnu.org
Fixes: 68fbcc344e ("hw/nvram: Introduce Xilinx eFuse QOM") # v6.2.0+
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20231121174051.63038-5-philmd@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'docs/devel/secure-coding-practices.rst')
0 files changed, 0 insertions, 0 deletions