summary refs log tree commit diff stats
path: root/docs/devel/secure-coding-practices.rst
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2020-06-29 11:28:04 -0500
committerPaolo Bonzini <pbonzini@redhat.com>2020-07-10 18:02:18 -0400
commit6553aa1d1166b4257f1294b898fc9f09e7276639 (patch)
tree7ff7b21a4d7d41b6c0b69687fbd9d3e2523e259a /docs/devel/secure-coding-practices.rst
parentb16c0e20c74218f2d69710cedad11da7dd4d2190 (diff)
downloadfocaccia-qemu-6553aa1d1166b4257f1294b898fc9f09e7276639.tar.gz
focaccia-qemu-6553aa1d1166b4257f1294b898fc9f09e7276639.zip
coverity: provide Coverity-friendly MIN_CONST and MAX_CONST
Coverity has problems seeing through __builtin_choose_expr, which
result in it abandoning analysis of later functions that utilize a
definition that used MIN_CONST or MAX_CONST, such as in qemu-file.c:

 50    DECLARE_BITMAP(may_free, MAX_IOV_SIZE);

CID 1429992 (#1 of 1): Unrecoverable parse warning (PARSE_ERROR)1.
expr_not_constant: expression must have a constant value

As has been done in the past (see 07d66672), it's okay to dumb things
down when compiling for static analyzers.  (Of course, now the
syntax-checker has a false positive on our reference to
__COVERITY__...)

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: CID 1429992, CID 1429995, CID 1429997, CID 1429999
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200629162804.1096180-1-eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'docs/devel/secure-coding-practices.rst')
0 files changed, 0 insertions, 0 deletions