summary refs log tree commit diff stats
path: root/docs/devel/secure-coding-practices.rst
diff options
context:
space:
mode:
authorFabiano Rosas <farosas@suse.de>2024-03-13 18:28:23 -0300
committerPeter Xu <peterx@redhat.com>2024-03-14 11:39:08 -0400
commit74228c598f139bd9ce7839794be9a3ccc180fb27 (patch)
tree0f7fd35b9c0054f96ad865bdd5ae75d79d72445b /docs/devel/secure-coding-practices.rst
parent20e6b1565306c9f537225e633c9a9fb67394937a (diff)
downloadfocaccia-qemu-74228c598f139bd9ce7839794be9a3ccc180fb27.tar.gz
focaccia-qemu-74228c598f139bd9ce7839794be9a3ccc180fb27.zip
migration: Fix iocs leaks during file and fd migration
The memory for the io channels is being leaked in three different ways
during file migration:

1) if the offset check fails we never drop the ioc reference;

2) we allocate an extra channel for no reason;

3) if multifd is enabled but channel creation fails when calling
   dup(), we leave the previous channels around along with the glib
   polling;

Fix all issues by restructuring the code to first allocate the
channels and only register the watches when all channels have been
created.

For multifd, the file and fd migrations can share code because both
are backed by a QIOChannelFile. For the non-multifd case, the fd needs
to be separate because it is backed by a QIOChannelSocket.

Fixes: 2dd7ee7a51 ("migration/multifd: Add incoming QIOChannelFile support")
Fixes: decdc76772 ("migration/multifd: Add mapped-ram support to fd: URI")
Reported-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240313212824.16974-2-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'docs/devel/secure-coding-practices.rst')
0 files changed, 0 insertions, 0 deletions