summary refs log tree commit diff stats
path: root/docs/devel/secure-coding-practices.rst
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2019-09-27 15:46:39 +0200
committerMarkus Armbruster <armbru@redhat.com>2019-09-28 17:17:48 +0200
commitc615550df306a7b16e75d21f65ee38898c756bac (patch)
tree1d2de035c046909657471164f51fddf51890457d /docs/devel/secure-coding-practices.rst
parent56d2df5e65d873ca0e9841f7bb7676cab759f8da (diff)
downloadfocaccia-qemu-c615550df306a7b16e75d21f65ee38898c756bac.tar.gz
focaccia-qemu-c615550df306a7b16e75d21f65ee38898c756bac.zip
qapi: Improve source file read error handling
qapi-gen.py crashes when it can't open the main schema file, and when
it can't read from any schema file.  Lazy.

Change QAPISchema.__init__() to take a file name instead of a file
object.  Move the open code from _include() to __init__(), so it's
used for the main schema file, too.

Move the read into the try for good measure, and rephrase the error
message.

Reporting open or read failure for the main schema file needs a
QAPISourceInfo representing "no source".  Make QAPISourceInfo cope
with fname=None.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-27-armbru@redhat.com>
Diffstat (limited to 'docs/devel/secure-coding-practices.rst')
0 files changed, 0 insertions, 0 deletions