summary refs log tree commit diff stats
path: root/docs/devel/writing-monitor-commands.rst
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2024-11-22 23:40:42 +0100
committerKevin Wolf <kwolf@redhat.com>2024-11-25 11:03:28 +0100
commit770de685353e8c495ad4773fbd4bc0db997e4dfd (patch)
treef966afb059d487f81156945db360af94ba3d3d00 /docs/devel/writing-monitor-commands.rst
parent5102f9df4a9a7adfbd902f9515c3f8f53dba288e (diff)
downloadfocaccia-qemu-770de685353e8c495ad4773fbd4bc0db997e4dfd.tar.gz
focaccia-qemu-770de685353e8c495ad4773fbd4bc0db997e4dfd.zip
tests/avocado/hotplug_blk: Fix addr in device_add command
pci_devfn properties accept both integer and string values, but
integer 1 and string '1' have different meanings: The integer value
means device 0, function 1 whereas the string value '1' is short for
'1.0' and means device 1, function 0.

This test wants the string version so that the device actually becomes
visible for the guest. device_add hides the problem because it goes
through QemuOpts, which turns all properties into strings - this is a
QEMU bug that we want to fix, but that cancelled out the bug in this
test.

Fix the test first so that device_add can be fixed afterwards.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20241122224042.149258-1-kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'docs/devel/writing-monitor-commands.rst')
0 files changed, 0 insertions, 0 deletions