summary refs log tree commit diff stats
path: root/docs/specs
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2020-06-30 11:03:49 +0200
committerMarkus Armbruster <armbru@redhat.com>2020-07-02 11:54:47 +0200
commit17d5d49a4e877b08ebf82aa33b349176281e68a3 (patch)
treed08b616006c9862724d924c6b958c9b10bb1a3de /docs/specs
parent2255f6b7966d981054397765a700e8a34c6a15c4 (diff)
downloadfocaccia-qemu-17d5d49a4e877b08ebf82aa33b349176281e68a3.tar.gz
focaccia-qemu-17d5d49a4e877b08ebf82aa33b349176281e68a3.zip
hw/arm/armsse: Fix armsse_realize() error API violation
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

armsse_realize() is wrong that way: it passes &err to
object_property_set_int() multiple times without checking it, and then
to sysbus_realize().  Harmless, because the former can't actually fail
here.

Fix by passing &error_abort instead.

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-25-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Diffstat (limited to 'docs/specs')
0 files changed, 0 insertions, 0 deletions