summary refs log tree commit diff stats
path: root/docs/sphinx/kernellog.py
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2020-03-19 19:33:19 +0000
committerPeter Maydell <peter.maydell@linaro.org>2020-04-14 09:44:31 +0100
commit062c73c51e19da0703d7505f9497a70e5398cf89 (patch)
tree30e7a4e7e9db5794211dab4df46bd64ca5abcca2 /docs/sphinx/kernellog.py
parentc160f17cd6f5fc3f8698b408a451149b34b1a647 (diff)
downloadfocaccia-qemu-062c73c51e19da0703d7505f9497a70e5398cf89.tar.gz
focaccia-qemu-062c73c51e19da0703d7505f9497a70e5398cf89.zip
thread.h: Fix Coverity version of qemu_cond_timedwait()
For Coverity's benefit, we provide simpler versions of functions like
qemu_mutex_lock(), qemu_cond_wait() and qemu_cond_timedwait().  When
we added qemu_cond_timedwait() in commit 3dcc9c6ec4ea, a cut and
paste error meant that the Coverity version of qemu_cond_timedwait()
was using the wrong _impl function, which makes the Coverity parser
complain:

"/qemu/include/qemu/thread.h", line 159: warning #140: too many arguments in
          function call
      return qemu_cond_timedwait(cond, mutex, ms);
             ^

"/qemu/include/qemu/thread.h", line 159: warning #120: return value type does
          not match the function type
      return qemu_cond_timedwait(cond, mutex, ms);
             ^

"/qemu/include/qemu/thread.h", line 156: warning #1563: function
          "qemu_cond_timedwait" not emitted, consider modeling it or review
          parse diagnostics to improve fidelity
  static inline bool (qemu_cond_timedwait)(QemuCond *cond, QemuMutex *mutex,
                      ^

These aren't fatal, but reduce the scope of the analysis. Fix the error.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200319193323.2038-3-peter.maydell@linaro.org
Diffstat (limited to 'docs/sphinx/kernellog.py')
0 files changed, 0 insertions, 0 deletions