summary refs log tree commit diff stats
path: root/fsdev/virtfs-proxy-helper.c
diff options
context:
space:
mode:
authorM. Mohan Kumar <mohan@in.ibm.com>2012-01-19 12:21:12 +0530
committerAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>2012-01-30 10:54:16 +0530
commit2d40564aaab3a99fe6ce00fc0fc893c02e9443ec (patch)
tree8b297266eff6d33d444051ded22b18f5b2669994 /fsdev/virtfs-proxy-helper.c
parent2c30dd744aa02d31a8a3b87daaba0b2cb774f346 (diff)
downloadfocaccia-qemu-2d40564aaab3a99fe6ce00fc0fc893c02e9443ec.tar.gz
focaccia-qemu-2d40564aaab3a99fe6ce00fc0fc893c02e9443ec.zip
hw/9pfs: Preserve S_ISGID
In passthrough security model in local fs driver, after a file creation
chown and chmod are done to set the file credentials and mode as requested
by 9p client. But if there was a request to create a file with S_ISGID
bit, doing chown on that file resets the S_ISGID bit. So first call
chown and then invoking chmod with proper mode bit retains the S_ISGID
(if present/requested)

This resulted in LTP mknod02, mknod03, mknod05, open10 test case
failures. This patch fixes this issue.

man 2 chown
When the owner or group of an executable file are changed by an unprivileged
user the S_ISUID  and  S_ISGID mode  bits are cleared.  POSIX does not specify
whether this also should happen when root does the chown(); the Linux behavior
depends on the kernel version.

Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Diffstat (limited to 'fsdev/virtfs-proxy-helper.c')
0 files changed, 0 insertions, 0 deletions