diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2019-12-05 20:46:22 +0300 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-12-18 08:43:19 +0100 |
| commit | 4c5ec47e639f8dbcede5b343b6d373127758e844 (patch) | |
| tree | dfaad8c33b063f3ac3fabe6195bed33d83c74a70 /hw/9pfs/9p-proxy.c | |
| parent | 0c115681a5194a53a4b373c4ff6d8b42ddd23b55 (diff) | |
| download | focaccia-qemu-4c5ec47e639f8dbcede5b343b6d373127758e844.tar.gz focaccia-qemu-4c5ec47e639f8dbcede5b343b6d373127758e844.zip | |
9pfs: make Error **errp const where it is appropriate
Mostly, Error ** is for returning error from the function, so the callee sets it. However error_append_security_model_hint and error_append_socket_sockfd_hint get already filled errp parameter. They don't change the pointer itself, only change the internal state of referenced Error object. So we can make it Error *const * errp, to stress the behavior. It will also help coccinelle script (in future) to distinguish such cases from common errp usage. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Acked-by: Greg Kurz <groug@kaod.org> Message-Id: <20191205174635.18758-9-vsementsov@virtuozzo.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> [Commit message replaced] Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'hw/9pfs/9p-proxy.c')
| -rw-r--r-- | hw/9pfs/9p-proxy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c index 97ab9c58a5..8136e1342d 100644 --- a/hw/9pfs/9p-proxy.c +++ b/hw/9pfs/9p-proxy.c @@ -1114,7 +1114,7 @@ static int connect_namedsocket(const char *path, Error **errp) return sockfd; } -static void error_append_socket_sockfd_hint(Error **errp) +static void error_append_socket_sockfd_hint(Error *const *errp) { error_append_hint(errp, "Either specify socket=/some/path where /some/path" " points to a listening AF_UNIX socket or sock_fd=fd" |