diff options
| author | Li Qiang <liqiang6-s@360.cn> | 2016-10-17 14:13:58 +0200 |
|---|---|---|
| committer | Greg Kurz <groug@kaod.org> | 2016-10-17 14:13:58 +0200 |
| commit | ff55e94d23ae94c8628b0115320157c763eb3e06 (patch) | |
| tree | 4c0e0e19c59eaf75b260996d2481c96f146deaac /hw/9pfs | |
| parent | eb687602853b4ae656e9236ee4222609f3a6887d (diff) | |
| download | focaccia-qemu-ff55e94d23ae94c8628b0115320157c763eb3e06.tar.gz focaccia-qemu-ff55e94d23ae94c8628b0115320157c763eb3e06.zip | |
9pfs: fix memory leak in v9fs_xattrcreate
The 'fs.xattr.value' field in V9fsFidState object doesn't consider the situation that this field has been allocated previously. Every time, it will be allocated directly. This leads to a host memory leak issue if the client sends another Txattrcreate message with the same fid number before the fid from the previous time got clunked. Signed-off-by: Li Qiang <liqiang6-s@360.cn> Reviewed-by: Greg Kurz <groug@kaod.org> [groug, updated the changelog to indicate how the leak can occur] Signed-off-by: Greg Kurz <groug@kaod.org>
Diffstat (limited to 'hw/9pfs')
| -rw-r--r-- | hw/9pfs/9p.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index bf23b011a8..66135cf121 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -3282,6 +3282,7 @@ static void coroutine_fn v9fs_xattrcreate(void *opaque) xattr_fidp->fs.xattr.flags = flags; v9fs_string_init(&xattr_fidp->fs.xattr.name); v9fs_string_copy(&xattr_fidp->fs.xattr.name, &name); + g_free(xattr_fidp->fs.xattr.value); xattr_fidp->fs.xattr.value = g_malloc0(size); err = offset; put_fid(pdu, file_fidp); |