summary refs log tree commit diff stats
path: root/hw/arm/netduino2.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2019-05-14 20:03:06 +0200
committerMarkus Armbruster <armbru@redhat.com>2019-05-22 14:57:33 +0200
commitb8c3511d086c65fa4bc2ca7a128bb3a56ac95306 (patch)
tree997af42ef7cfbd852cc6ca4e31350428b0d2a6e9 /hw/arm/netduino2.c
parenta4f667b6714916683408b983cfe0a615a725775f (diff)
downloadfocaccia-qemu-b8c3511d086c65fa4bc2ca7a128bb3a56ac95306.tar.gz
focaccia-qemu-b8c3511d086c65fa4bc2ca7a128bb3a56ac95306.zip
qemu-bridge-helper: Fix misuse of isspace()
parse_acl_file() passes char values to isspace().  Undefined behavior
when the value is negative.  Not a security issue, because the
characters come from trusted $prefix/etc/qemu/bridge.conf and the
files it includes.

Furthermore, isspace()'s locale-dependence means qemu-bridge-helper
uses the user's locale for parsing $prefix/etc/bridge.conf.  Feels
wrong.

Use g_ascii_isspace() instead.  This fixes the undefined behavior, and
makes parsing of $prefix/etc/bridge.conf locale-independent.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190514180311.16028-2-armbru@redhat.com>
Diffstat (limited to 'hw/arm/netduino2.c')
0 files changed, 0 insertions, 0 deletions