diff options
| author | Gavin Shan <gshan@redhat.com> | 2023-12-04 10:47:18 +1000 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-01-05 16:20:14 +0100 |
| commit | b9f452142cf4d47d97f6e6e2b727c9237443eb0f (patch) | |
| tree | 5d6107f9b07cdc11821c3703d7913976aa687220 /hw/arm/virt.c | |
| parent | 62b4a227a330c76f5a7bac5d0ba903dfd1c3c9c1 (diff) | |
| download | focaccia-qemu-b9f452142cf4d47d97f6e6e2b727c9237443eb0f.tar.gz focaccia-qemu-b9f452142cf4d47d97f6e6e2b727c9237443eb0f.zip | |
machine: Use error handling when CPU type is checked
Functions that use an Error **errp parameter to return errors should not also report them to the user, because reporting is the caller's job. The principle is violated by machine_run_board_init() because it calls error_report(), error_printf(), and exit(1) when the machine doesn't support the requested CPU type. Clean this up by using error_setg() and error_append_hint() instead. No functional change, as the only caller passes &error_fatal. Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Gavin Shan <gshan@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Message-ID: <20231204004726.483558-2-gshan@redhat.com> [PMD: Correct error_append_hint() argument] Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'hw/arm/virt.c')
0 files changed, 0 insertions, 0 deletions