summary refs log tree commit diff stats
path: root/hw/char/goldfish_tty.c
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2024-07-22 13:25:01 +0200
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2024-07-23 22:34:54 +0200
commit06252bf5122f047ed5c14fb75f3167f11b882352 (patch)
treee952ab6e63bee8853a3a7d0be336208a46ce9c74 /hw/char/goldfish_tty.c
parent06a16e7ba98438087b8806bad0ddf094380892a9 (diff)
downloadfocaccia-qemu-06252bf5122f047ed5c14fb75f3167f11b882352.tar.gz
focaccia-qemu-06252bf5122f047ed5c14fb75f3167f11b882352.zip
util/fifo8: Rename fifo8_pop_buf() -> fifo8_pop_bufptr()
Since fifo8_pop_buf() return a const buffer (which points
directly into the FIFO backing store). Rename it using the
'bufptr' suffix to better reflect that it is a pointer to
the internal buffer that is being returned. This will help
differentiate with methods *copying* the FIFO data.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20240722160745.67904-6-philmd@linaro.org>
Diffstat (limited to 'hw/char/goldfish_tty.c')
-rw-r--r--hw/char/goldfish_tty.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/char/goldfish_tty.c b/hw/char/goldfish_tty.c
index cdff46bc13..c2e1f6537f 100644
--- a/hw/char/goldfish_tty.c
+++ b/hw/char/goldfish_tty.c
@@ -109,7 +109,7 @@ static void goldfish_tty_cmd(GoldfishTTYState *s, uint32_t cmd)
         len = s->data_len;
         ptr = s->data_ptr;
         while (len && !fifo8_is_empty(&s->rx_fifo)) {
-            const uint8_t *buf = fifo8_pop_buf(&s->rx_fifo, len, &to_copy);
+            const uint8_t *buf = fifo8_pop_bufptr(&s->rx_fifo, len, &to_copy);
 
             dma_memory_write_relaxed(&address_space_memory, ptr, buf, to_copy);