summary refs log tree commit diff stats
path: root/hw/core/cpu-common.c
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2024-01-02 10:06:17 +1100
committerPaolo Bonzini <pbonzini@redhat.com>2024-01-18 10:43:14 +0100
commita58506b748b8988a95f4fa1a2420ac5c17038b30 (patch)
tree4daced2875bac1086aa2050dc2e87e3d566de520 /hw/core/cpu-common.c
parent3cbc17ee92479ff56d0d6afecc0def6f7ec01153 (diff)
downloadfocaccia-qemu-a58506b748b8988a95f4fa1a2420ac5c17038b30.tar.gz
focaccia-qemu-a58506b748b8988a95f4fa1a2420ac5c17038b30.zip
target/i386: Do not re-compute new pc with CF_PCREL
With PCREL, we have a page-relative view of EIP, and an
approximation of PC = EIP+CSBASE that is good enough to
detect page crossings.  If we try to recompute PC after
masking EIP, we will mess up that approximation and write
a corrupt value to EIP.

We already handled masking properly for PCREL, so the
fix in b5e0d5d2 was only needed for the !PCREL path.

Cc: qemu-stable@nongnu.org
Fixes: b5e0d5d22fbf ("target/i386: Fix 32-bit wrapping of pc/eip computation")
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20240101230617.129349-1-richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/core/cpu-common.c')
0 files changed, 0 insertions, 0 deletions