summary refs log tree commit diff stats
path: root/hw/core/null-machine.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2022-02-21 19:21:21 +0000
committerMarkus Armbruster <armbru@redhat.com>2022-02-28 11:39:35 +0100
commit1f216b8ca961e95c221a5e9c84d264ab0f3d7667 (patch)
tree8aff4eeffd63f1ca52f8cc56fa6400f50399cf26 /hw/core/null-machine.c
parentb1ca53224a9161292a2801f0f41377f3ee83c609 (diff)
downloadfocaccia-qemu-1f216b8ca961e95c221a5e9c84d264ab0f3d7667.tar.gz
focaccia-qemu-1f216b8ca961e95c221a5e9c84d264ab0f3d7667.zip
qapi: Move RTC_CHANGE back out of target schema
This commit effectively reverts commit 183e4281a30962, which moved
the RTC_CHANGE event to the target schema.  That change was an
attempt to make the event target-specific to improve introspection,
but the event isn't really target-specific: it's machine or device
specific.  Putting RTC_CHANGE in the target schema with an ifdef list
reduces maintainability (by adding an if: list with a long list of
targets that needs to be manually updated as architectures are added
or removed or as new devices gain the RTC_CHANGE functionality) and
increases compile time (by preventing RTC devices which emit the
event from being "compile once" rather than "compile once per
target", because qapi-events-misc-target.h uses TARGET_* ifdefs,
which are poisoned in "compile once" files.)

Move RTC_CHANGE back to misc.json.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220221192123.749970-2-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'hw/core/null-machine.c')
0 files changed, 0 insertions, 0 deletions