summary refs log tree commit diff stats
path: root/hw/core/or-irq.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2018-06-15 14:57:13 +0100
committerPeter Maydell <peter.maydell@linaro.org>2018-06-15 15:23:34 +0100
commit95f875654ae8b433b50a2bc7858e34af957cbaa4 (patch)
tree3416374f6a53462d06660fb86f7298185bf4e7fb /hw/core/or-irq.c
parent38d81dafb316291356db9591e6752b27848b2ea4 (diff)
downloadfocaccia-qemu-95f875654ae8b433b50a2bc7858e34af957cbaa4.tar.gz
focaccia-qemu-95f875654ae8b433b50a2bc7858e34af957cbaa4.zip
arm: Don't crash if user tries to use a Cortex-M CPU without an NVIC
The Cortex-M CPU and its NVIC are two intimately intertwined parts of
the same hardware; it is not possible to use one without the other.
Unfortunately a lot of our board models don't do any sanity checking
on the CPU type the user asks for, so a command line like
    qemu-system-arm -M versatilepb -cpu cortex-m3
will create an M3 without an NVIC, and coredump immediately.
In the other direction, trying a non-M-profile CPU in an M-profile
board won't blow up, but doesn't do anything useful either:
    qemu-system-arm -M lm3s6965evb -cpu arm926

Add some checking in the NVIC and CPU realize functions that the
user isn't trying to use an NVIC without an M-profile CPU or
an M-profile CPU without an NVIC, so we can produce a helpful
error message rather than a core dump.

Fixes: https://bugs.launchpad.net/qemu/+bug/1766896
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180601160355.15393-1-peter.maydell@linaro.org
Diffstat (limited to 'hw/core/or-irq.c')
0 files changed, 0 insertions, 0 deletions