diff options
| author | Max Reitz <mreitz@redhat.com> | 2019-09-02 21:33:16 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2019-09-10 08:58:43 +0200 |
| commit | 1a37e3124407b5a145d44478d3ecbdb89c63789f (patch) | |
| tree | 4d588f07e8984bc24218fd47a410b22f0ec1d812 /hw/core/qdev-properties-system.c | |
| parent | effecce6bcb830a661c882d7299b53382b56a131 (diff) | |
| download | focaccia-qemu-1a37e3124407b5a145d44478d3ecbdb89c63789f.tar.gz focaccia-qemu-1a37e3124407b5a145d44478d3ecbdb89c63789f.zip | |
vpc: Return 0 from vpc_co_create() on success
blockdev_create_run() directly uses .bdrv_co_create()'s return value as the job's return value. Jobs must return 0 on success, not just any nonnegative value. Therefore, using blockdev-create for VPC images may currently fail as the vpc driver may return a positive integer. Because there is no point in returning a positive integer anywhere in the block layer (all non-negative integers are generally treated as complete success), we probably do not want to add more such cases. Therefore, fix this problem by making the vpc driver always return 0 in case of success. Suggested-by: Kevin Wolf <kwolf@redhat.com> Cc: qemu-stable@nongnu.org Signed-off-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/core/qdev-properties-system.c')
0 files changed, 0 insertions, 0 deletions