summary refs log tree commit diff stats
path: root/hw/core/qdev-properties-system.c
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2019-07-19 15:14:22 +0200
committerLaurent Vivier <laurent@vivier.eu>2019-08-21 10:56:19 +0200
commit5a70b8b550a8e236fd7f696c803fc05c4cae2a54 (patch)
tree9b779737f87a03c5bcb1c9a6fe60c0469ef04f6e /hw/core/qdev-properties-system.c
parent45a9eacead727164b3b76087ed93046a4b974a34 (diff)
downloadfocaccia-qemu-5a70b8b550a8e236fd7f696c803fc05c4cae2a54.tar.gz
focaccia-qemu-5a70b8b550a8e236fd7f696c803fc05c4cae2a54.zip
hw/ipmi: Rewrite a fall through comment
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
  hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
    178 |         ch |= 0x10;
        |         ~~~^~~~~~~
  hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
    181 |     default:
        |     ^~~~~~~
  cc1: all warnings being treated as errors
  make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Message-Id: <20190719131425.10835-5-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/core/qdev-properties-system.c')
0 files changed, 0 insertions, 0 deletions