summary refs log tree commit diff stats
path: root/hw/core/qdev-properties-system.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2017-03-22 22:00:05 +0100
committerMax Reitz <mreitz@redhat.com>2017-03-27 16:53:42 +0200
commite5bcf967fb80ff9cf4d0c0d643e985ec5ff94e91 (patch)
tree8c4ebc20c2a2a3a646822f0742e7c1944b1734bb /hw/core/qdev-properties-system.c
parenta12a712a7dfbd2e2f4882ef2c90a9b2162166dd7 (diff)
downloadfocaccia-qemu-e5bcf967fb80ff9cf4d0c0d643e985ec5ff94e91.tar.gz
focaccia-qemu-e5bcf967fb80ff9cf4d0c0d643e985ec5ff94e91.zip
file-posix: Make bdrv_flush() failure permanent without O_DIRECT
Success for bdrv_flush() means that all previously written data is safe
on disk. For fdatasync(), the best semantics we can hope for on Linux
(without O_DIRECT) is that all data that was written since the last call
was successfully written back. Therefore, and because we can't redo all
writes after a flush failure, we have to give up after a single
fdatasync() failure. After this failure, we would never be able to make
the promise that a successful bdrv_flush() makes.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 20170322210005.16533-1-kwolf@redhat.com
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'hw/core/qdev-properties-system.c')
0 files changed, 0 insertions, 0 deletions