summary refs log tree commit diff stats
path: root/hw/core/qdev.c
diff options
context:
space:
mode:
authorDenis V. Lunev <den@openvz.org>2015-11-09 10:24:04 +0300
committerJuan Quintela <quintela@redhat.com>2015-11-10 15:00:28 +0100
commit15b3b8eaae8dbcc903bb164311ea0066c77536a7 (patch)
treec43b14910a4b996b350a0e952b773988b5f00662 /hw/core/qdev.c
parent371ff5a3f04cd7d05bab49ac6e80da319026d95b (diff)
downloadfocaccia-qemu-15b3b8eaae8dbcc903bb164311ea0066c77536a7.tar.gz
focaccia-qemu-15b3b8eaae8dbcc903bb164311ea0066c77536a7.zip
migration: qemu_savevm_state_cleanup becomes mandatory operation
since commit
    commit 94f5a43704129ca4995aa3385303c5ae225bde42
    Author: Liang Li <liang.z.li@intel.com>
    Date:   Mon Nov 2 15:37:00 2015 +0800

    migration: defer migration_end & blk_mig_cleanup

when actual .cleanup callbacks calling was removed from complete operations.

The patch fixes regression introduced by the commit above results in
100% reliable assert for virtio-scsi VM with iothreads enabled during
'virsh create-snapshot' operation:
    assert(i != mr->ioeventfd_nb);
    memory_region_del_eventfd
    virtio_pci_set_host_notifier_internal
    virtio_pci_set_host_notifier
    virtio_scsi_dataplane_start
    virtio_scsi_handle_cmd
    virtio_queue_notify_vq
    virtio_queue_host_notifier_read
    aio_dispatch

Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Liang Li <liang.z.li@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'hw/core/qdev.c')
0 files changed, 0 insertions, 0 deletions