summary refs log tree commit diff stats
path: root/hw/core/qdev.c
diff options
context:
space:
mode:
authorLuiz Capitulino <lcapitulino@redhat.com>2013-12-29 22:39:58 -0500
committerLuiz Capitulino <lcapitulino@redhat.com>2014-01-06 15:02:30 -0500
commitc950114286ea358a93ce632db0421945e1008395 (patch)
tree0edaf2258112053a47ab7ebba377d0f461eecd32 /hw/core/qdev.c
parent594278718323ca7bffaab0fb7fc6c82fa2c1cd5f (diff)
downloadfocaccia-qemu-c950114286ea358a93ce632db0421945e1008395.tar.gz
focaccia-qemu-c950114286ea358a93ce632db0421945e1008395.zip
migration: qmp_migrate(): keep working after syntax error
If a user or QMP client enter a bad syntax for the migrate
command in QMP/HMP, then the migrate command will never succeed
from that point on.

For example, if you enter:

(qemu) migrate tcp;0:4444
migrate: Parameter 'uri' expects a valid migration protocol

Then the migrate command will always fail from now on:

(qemu) migrate tcp:0:4444
migrate: There's a migration process in progress

The problem is that qmp_migrate() sets the migration status to
MIG_STATE_SETUP and doesn't reset it on syntax error. This bug
was introduced by commit 29ae8a4133082e16970c9d4be09f4b6a15034617.

Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'hw/core/qdev.c')
0 files changed, 0 insertions, 0 deletions