summary refs log tree commit diff stats
path: root/hw/core/vm-change-state-handler.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2019-06-20 18:37:09 +0100
committerKevin Wolf <kwolf@redhat.com>2019-07-08 16:00:26 +0200
commit1a8c091c4ea5db3126514e3f7df678c9ee328802 (patch)
tree15149cf49a60253597d6df16ca91380e681096db /hw/core/vm-change-state-handler.c
parente965ffa70ac8ddc334dd5990f6907789bd9e6af6 (diff)
downloadfocaccia-qemu-1a8c091c4ea5db3126514e3f7df678c9ee328802.tar.gz
focaccia-qemu-1a8c091c4ea5db3126514e3f7df678c9ee328802.zip
virtio-scsi: restart DMA after iothread
When the 'cont' command resumes guest execution the vm change state
handlers are invoked.  Unfortunately there is no explicit ordering
between classic qemu_add_vm_change_state_handler() callbacks.  When two
layers of code both use vm change state handlers, we don't control which
handler runs first.

virtio-scsi with iothreads hits a deadlock when a failed SCSI command is
restarted and completes before the iothread is re-initialized.

This patch uses the new qdev_add_vm_change_state_handler() API to
guarantee that virtio-scsi's virtio change state handler executes before
the SCSI bus children.  This way DMA is restarted after the iothread has
re-initialized.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/core/vm-change-state-handler.c')
0 files changed, 0 insertions, 0 deletions