summary refs log tree commit diff stats
path: root/hw/core
diff options
context:
space:
mode:
authorArun Menon <armenon@redhat.com>2025-09-18 20:53:44 +0530
committerPeter Xu <peterx@redhat.com>2025-10-03 09:48:02 -0400
commit42e556fa3f7acfd0d0bc834dd0b002eb24d20eea (patch)
tree941a67cc99091d93aa1a33a44e60d31d2e23b7d9 /hw/core
parent40de712a89d8fe26af398dd23c24e94834ca442b (diff)
downloadfocaccia-qemu-42e556fa3f7acfd0d0bc834dd0b002eb24d20eea.tar.gz
focaccia-qemu-42e556fa3f7acfd0d0bc834dd0b002eb24d20eea.zip
backends/tpm: Propagate vTPM error on migration failure
- When migration of a VM with encrypted vTPM fails on the
  destination host, (e.g., due to a mismatch in secret values),
  the error message displayed on the source host is generic and unhelpful.
- For example, a typical error looks like this:
  "operation failed: job 'migration out' failed: Sibling indicated error 1.
  operation failed: job 'migration in' failed: load of migration failed:
  Input/output error"
- Such generic errors are logged using error_report(), which prints to
  the console/monitor but does not make the detailed error accessible via
  the QMP query-migrate command.
- This change, along with the set of changes of passing errp Error object
  to the VM state loading functions, help in addressing the issue.
  We use the post_load_errp hook of VMStateDescription to propagate errors
  by setting Error **errp objects in case of failure in the TPM backend.
- It can then be retrieved using QMP command:
  {"execute" : "query-migrate"}

Buglink: https://issues.redhat.com/browse/RHEL-82826

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Arun Menon <armenon@redhat.com>
Tested-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20250918-propagate_tpm_error-v14-27-36f11a6fb9d3@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'hw/core')
0 files changed, 0 insertions, 0 deletions