diff options
| author | Peter Xu <peterx@redhat.com> | 2023-10-20 11:07:27 +0200 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-11-01 16:13:58 +0100 |
| commit | caa91b3c44cdb2d2921e25eda554d38c527e6c47 (patch) | |
| tree | 55260445480d222b719adf5add604ea7547bd26b /hw/core | |
| parent | 485fb95546e1cc94e77b93ff785bdbfa2c1d3ff1 (diff) | |
| download | focaccia-qemu-caa91b3c44cdb2d2921e25eda554d38c527e6c47.tar.gz focaccia-qemu-caa91b3c44cdb2d2921e25eda554d38c527e6c47.zip | |
migration: Check in savevm_state_handler_insert for dups
Before finally register one SaveStateEntry, we detect for duplicated entries. This could be helpful to notify us asap instead of get silent migration failures which could be hard to diagnose. For example, this patch will generate a message like this (if without previous fixes on x2apic) as long as we wants to boot a VM instance with "-smp 200,maxcpus=288,sockets=2,cores=72,threads=2" and QEMU will bail out even before VM starts: savevm_state_handler_insert: Detected duplicate SaveStateEntry: id=apic, instance_id=0x0 Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> Message-ID: <20231020090731.28701-10-quintela@redhat.com>
Diffstat (limited to 'hw/core')
0 files changed, 0 insertions, 0 deletions