summary refs log tree commit diff stats
path: root/hw/cris/boot.c
diff options
context:
space:
mode:
authorBALATON Zoltan <balaton@eik.bme.hu>2020-07-05 19:22:11 +0200
committerAlistair Francis <alistair.francis@wdc.com>2020-09-25 16:52:08 -0700
commit617160c9e1f8022563c33aa7fd204535d4d49f8c (patch)
tree9bdc09357ec3690c71f21058d88bada7b977bb33 /hw/cris/boot.c
parent8d16e72f2d4df2c9e631393adf1669a1da7efe8a (diff)
downloadfocaccia-qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.tar.gz
focaccia-qemu-617160c9e1f8022563c33aa7fd204535d4d49f8c.zip
load_elf: Remove unused address variables from callers
Several callers of load_elf() pass pointers for lowaddr and highaddr
parameters which are then not used for anything. This may stem from a
misunderstanding that load_elf need a value here but in fact it can
take NULL to ignore these values. Remove such unused variables and
pass NULL instead from callers that don't need these.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200705174020.BDD0174633F@zero.eik.bme.hu>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Diffstat (limited to 'hw/cris/boot.c')
-rw-r--r--hw/cris/boot.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/cris/boot.c b/hw/cris/boot.c
index b8947bc660..aa8d2756d6 100644
--- a/hw/cris/boot.c
+++ b/hw/cris/boot.c
@@ -67,7 +67,7 @@ static uint64_t translate_kernel_address(void *opaque, uint64_t addr)
 void cris_load_image(CRISCPU *cpu, struct cris_load_info *li)
 {
     CPUCRISState *env = &cpu->env;
-    uint64_t entry, high;
+    uint64_t entry;
     int kcmdline_len;
     int image_size;
 
@@ -76,7 +76,7 @@ void cris_load_image(CRISCPU *cpu, struct cris_load_info *li)
        devboard SDK.  */
     image_size = load_elf(li->image_filename, NULL,
                           translate_kernel_address, NULL,
-                          &entry, NULL, &high, NULL, 0, EM_CRIS, 0, 0);
+                          &entry, NULL, NULL, NULL, 0, EM_CRIS, 0, 0);
     li->entry = entry;
     if (image_size < 0) {
         /* Takes a kimage from the axis devboard SDK.  */