summary refs log tree commit diff stats
path: root/hw/cxl/cxl-device-utils.c
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2022-08-08 13:20:51 +0100
committerMichael S. Tsirkin <mst@redhat.com>2022-08-17 13:08:11 -0400
commitd2289b524e71970ea8ca5602f219cc92b8e5896b (patch)
tree48fa641428d2e25a9e8a8449d572796ce8a3f428 /hw/cxl/cxl-device-utils.c
parenta99fbb003b2558cb4ff426d8144eff7cc1e2d7dc (diff)
downloadfocaccia-qemu-d2289b524e71970ea8ca5602f219cc92b8e5896b.tar.gz
focaccia-qemu-d2289b524e71970ea8ca5602f219cc92b8e5896b.zip
hw/cxl: Fix wrong query of target ports
Two issues were present in this code:
1) Check on which register to look in was inverted.
2) Both branches use the _LO register.

Whilst here moved to extract32() rather than hand rolling
the field extraction as simpler and hopefully less error prone.

Fixes Coverity CID: 1488873

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220808122051.14822-3-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/cxl/cxl-device-utils.c')
0 files changed, 0 insertions, 0 deletions