diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2018-08-14 13:39:47 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2018-08-15 12:50:39 +0200 |
| commit | 8d65a3ccfd5db7f0436e095cd952f5d0c3a873ba (patch) | |
| tree | 992808740753702f7d313d2e07db9b8553881ea0 /hw/display/framebuffer.c | |
| parent | 86fae10c64d642256cf019e6829929fa0d259c7a (diff) | |
| download | focaccia-qemu-8d65a3ccfd5db7f0436e095cd952f5d0c3a873ba.tar.gz focaccia-qemu-8d65a3ccfd5db7f0436e095cd952f5d0c3a873ba.zip | |
qemu-img: fix regression copying secrets during convert
When the convert command is creating an output file that needs
secrets, we need to ensure those secrets are passed to both the
blk_new_open and bdrv_create API calls.
This is done by qemu-img extracting all opts matching the name
suffix "key-secret". Unfortunately the code doing this was run after the
call to bdrv_create(), which meant the QemuOpts it was extracting
secrets from was now empty.
Previously this worked by luks as a bug meant the "key-secret"
parameters were not purged from the QemuOpts. This bug was fixed in
commit b76b4f604521e59f857d6177bc55f6f2e41fd392
Author: Kevin Wolf <kwolf@redhat.com>
Date: Thu Jan 11 16:18:08 2018 +0100
qcow2: Use visitor for options in qcow2_create()
Exposing the latent bug in qemu-img. This fix simply moves the copying
of secrets to before the bdrv_create() call.
Cc: qemu-stable@nongnu.org
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw/display/framebuffer.c')
0 files changed, 0 insertions, 0 deletions