summary refs log tree commit diff stats
path: root/hw/display
diff options
context:
space:
mode:
authorDongwon Kim <dongwon.kim@intel.com>2023-06-21 15:27:04 -0700
committerMarc-André Lureau <marcandre.lureau@redhat.com>2023-06-27 17:08:56 +0200
commitec4d71e8f21c90033cb3c77101a434cb9ea708e9 (patch)
tree5d17fb4afa6accc1ca1aa7d919467fa18b350136 /hw/display
parent34e29d85a7734802317c4cac9ad52b10d461c1dc (diff)
downloadfocaccia-qemu-ec4d71e8f21c90033cb3c77101a434cb9ea708e9.tar.gz
focaccia-qemu-ec4d71e8f21c90033cb3c77101a434cb9ea708e9.zip
virtio-gpu-udmabuf: create udmabuf for blob even when iov_cnt == 1
There were often cases where a scanout blob sometimes has just 1 entry
that is linked to many pages in it. So just checking whether iov_cnt is 1
is not enough for screening small, non-scanout blobs. Therefore adding
iov_len check as well to make sure it creates an udmabuf only for a scanout
blob, which is at least bigger than one page size.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20230621222704.29932-1-dongwon.kim@intel.com>
Diffstat (limited to 'hw/display')
-rw-r--r--hw/display/virtio-gpu-udmabuf.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/display/virtio-gpu-udmabuf.c b/hw/display/virtio-gpu-udmabuf.c
index 69e2cf0bd6..ef1a740de5 100644
--- a/hw/display/virtio-gpu-udmabuf.c
+++ b/hw/display/virtio-gpu-udmabuf.c
@@ -132,7 +132,8 @@ void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
     void *pdata = NULL;
 
     res->dmabuf_fd = -1;
-    if (res->iov_cnt == 1) {
+    if (res->iov_cnt == 1 &&
+        res->iov[0].iov_len < 4096) {
         pdata = res->iov[0].iov_base;
     } else {
         virtio_gpu_create_udmabuf(res);